Skip to content

Commit

Permalink
nilfs2: remove nilfs_segctor_init() in segment.c
Browse files Browse the repository at this point in the history
There are only two lines of code in nilfs_segctor_init(). From a logic
design view, the first line 'sci->sc_seq_done = sci->sc_seq_request;'
should be put in nilfs_segctor_new(). Even in nilfs_segctor_new(),
this initialization is needless because sci is kzalloc-ed. So
nilfs_segctor_init() is only a wrap call to
nilfs_segctor_start_thread().

Signed-off-by: Li Hong <lihong.hi@gmail.com>
Signed-off-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
  • Loading branch information
Li Hong authored and Ryusuke Konishi committed May 10, 2010
1 parent 50614bc commit 154ac5a
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions fs/nilfs2/segment.c
Original file line number Diff line number Diff line change
Expand Up @@ -2685,13 +2685,6 @@ static void nilfs_segctor_kill_thread(struct nilfs_sc_info *sci)
}
}

static int nilfs_segctor_init(struct nilfs_sc_info *sci)
{
sci->sc_seq_done = sci->sc_seq_request;

return nilfs_segctor_start_thread(sci);
}

/*
* Setup & clean-up functions
*/
Expand Down Expand Up @@ -2815,7 +2808,7 @@ int nilfs_attach_segment_constructor(struct nilfs_sb_info *sbi)
return -ENOMEM;

nilfs_attach_writer(nilfs, sbi);
err = nilfs_segctor_init(NILFS_SC(sbi));
err = nilfs_segctor_start_thread(NILFS_SC(sbi));
if (err) {
nilfs_detach_writer(nilfs, sbi);
kfree(sbi->s_sc_info);
Expand Down

0 comments on commit 154ac5a

Please sign in to comment.