Skip to content

Commit

Permalink
selftests/ftrace: Fix to use remount when testing mount GID option
Browse files Browse the repository at this point in the history
Fix mount_options.tc to use remount option to mount the tracefs.
Since the current implementation does not umount the tracefs,
this test always fails because of -EBUSY error.
Using remount option will allow us to change the mount option.

Link: https://lore.kernel.org/r/173625186741.1383744.16707876180798573039.stgit@devnote2
Fixes: 8b55572 ("tracing/selftests: Add tracefs mount options test")
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Cc: stable@vger.kernel.org
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
  • Loading branch information
Masami Hiramatsu (Google) authored and Shuah Khan committed Jan 15, 2025
1 parent 58beae2 commit 159ca65
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ find_alternate_gid() {
tac /etc/group | grep -v ":$original_gid:" | head -1 | cut -d: -f3
}

mount_tracefs_with_options() {
remount_tracefs_with_options() {
local mount_point="$1"
local options="$2"

mount -t tracefs -o "$options" nodev "$mount_point"
mount -t tracefs -o "remount,$options" nodev "$mount_point"

setup
}
Expand Down Expand Up @@ -81,7 +81,7 @@ test_gid_mount_option() {

# Unmount existing tracefs instance and mount with new GID
unmount_tracefs "$mount_point"
mount_tracefs_with_options "$mount_point" "$new_options"
remount_tracefs_with_options "$mount_point" "$new_options"

check_gid "$mount_point" "$other_group"

Expand All @@ -92,7 +92,7 @@ test_gid_mount_option() {

# Unmount and remount with the original GID
unmount_tracefs "$mount_point"
mount_tracefs_with_options "$mount_point" "$mount_options"
remount_tracefs_with_options "$mount_point" "$mount_options"
check_gid "$mount_point" "$original_group"
}

Expand Down

0 comments on commit 159ca65

Please sign in to comment.