Skip to content

Commit

Permalink
spi: spi-topcliff-pch: drop call to wakeup-disable
Browse files Browse the repository at this point in the history
Before generic upgrade, both .suspend() and .resume() were invoking
pci_enable_wake(pci_dev, PCI_D3hot, 0). Hence, disabling wakeup in both
states. (Normal trend is .suspend() enables and .resume() disables the
wakeup.)

This was ambiguous and may be buggy. Instead of replicating the legacy
behavior, drop the wakeup-disable call.

Fixes: f185bcc ("spi: spi-topcliff-pch: use generic power management")
Reported-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20200727172936.661567-1-vaibhavgupta40@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Vaibhav Gupta authored and Mark Brown committed Jul 28, 2020
1 parent aa9e862 commit 15b413d
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/spi/spi-topcliff-pch.c
Original file line number Diff line number Diff line change
Expand Up @@ -1652,8 +1652,6 @@ static int __maybe_unused pch_spi_resume(struct device *dev)

dev_dbg(dev, "%s ENTRY\n", __func__);

device_wakeup_disable(dev);

/* set suspend status to false */
pd_dev_save->board_dat->suspend_sts = false;

Expand Down

0 comments on commit 15b413d

Please sign in to comment.