Skip to content

Commit

Permalink
drm/mcde: Fix an error handling path in 'mcde_probe()'
Browse files Browse the repository at this point in the history
If we don't find any matching components, we should go through the error
handling path, in order to free some resources.

Fixes: ca5be90 ("drm/mcde: Fix uninitialized variable")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20190822211518.5578-1-christophe.jaillet@wanadoo.fr
  • Loading branch information
Christophe JAILLET authored and Linus Walleij committed Aug 26, 2019
1 parent d72cf01 commit 15c665b
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/gpu/drm/mcde/mcde_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,8 @@ static int mcde_probe(struct platform_device *pdev)
}
if (!match) {
dev_err(dev, "no matching components\n");
return -ENODEV;
ret = -ENODEV;
goto clk_disable;
}
if (IS_ERR(match)) {
dev_err(dev, "could not create component match\n");
Expand Down

0 comments on commit 15c665b

Please sign in to comment.