Skip to content

Commit

Permalink
dmaengine: mmp_pdma: fix mismerge
Browse files Browse the repository at this point in the history
The merge between 2b7f65b "mmp_pdma: Style neatening" and
8010dad "dma: add dma_get_any_slave_channel(), for use in of_xlate()"
caused a build error by leaving obsolete code in place:

  mmp_pdma.c: In function 'mmp_pdma_dma_xlate':
  mmp_pdma.c:909:31: error: 'candidate' undeclared
  mmp_pdma.c:912:3: error: label 'retry' used but not defined
  mmp_pdma.c:901:24: warning: unused variable 'c' [-Wunused-variable]

This removes the extraneous lines.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
  • Loading branch information
Arnd Bergmann authored and Vinod Koul committed Jan 29, 2014
1 parent 6d05c9f commit 15cec53
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions drivers/dma/mmp_pdma.c
Original file line number Diff line number Diff line change
Expand Up @@ -899,19 +899,11 @@ static struct dma_chan *mmp_pdma_dma_xlate(struct of_phandle_args *dma_spec,
{
struct mmp_pdma_device *d = ofdma->of_dma_data;
struct dma_chan *chan;
struct mmp_pdma_chan *c;

chan = dma_get_any_slave_channel(&d->device);
if (!chan)
return NULL;

/* dma_get_slave_channel will return NULL if we lost a race between
* the lookup and the reservation */
chan = dma_get_slave_channel(candidate);

if (!chan)
goto retry;

to_mmp_pdma_chan(chan)->drcmr = dma_spec->args[0];

return chan;
Expand Down

0 comments on commit 15cec53

Please sign in to comment.