Skip to content

Commit

Permalink
x86: Demacro CONFIG_PARAVIRT cpu accessors
Browse files Browse the repository at this point in the history
Recently, we had a build failure on !CONFIG_PARAVIRT due to a
callback ->wbinvd() clashing with a macro wbinvd().

While we worked around the issue, avoid it in the future by
changing the macro (and a few surrounding ones) to an inline
function.

Signed-off-by: Avi Kivity <avi@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Link: http://lkml.kernel.org/r/1303632711-21662-1-git-send-email-avi@redhat.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Avi Kivity authored and Ingo Molnar committed Apr 24, 2011
1 parent 0f1d9f7 commit 15d6aba
Showing 1 changed file with 71 additions and 14 deletions.
85 changes: 71 additions & 14 deletions arch/x86/include/asm/system.h
Original file line number Diff line number Diff line change
Expand Up @@ -303,24 +303,81 @@ static inline void native_wbinvd(void)
#ifdef CONFIG_PARAVIRT
#include <asm/paravirt.h>
#else
#define read_cr0() (native_read_cr0())
#define write_cr0(x) (native_write_cr0(x))
#define read_cr2() (native_read_cr2())
#define write_cr2(x) (native_write_cr2(x))
#define read_cr3() (native_read_cr3())
#define write_cr3(x) (native_write_cr3(x))
#define read_cr4() (native_read_cr4())
#define read_cr4_safe() (native_read_cr4_safe())
#define write_cr4(x) (native_write_cr4(x))
#define wbinvd() (native_wbinvd())

static inline unsigned long read_cr0(void)
{
return native_read_cr0();
}

static inline void write_cr0(unsigned long x)
{
native_write_cr0(x);
}

static inline unsigned long read_cr2(void)
{
return native_read_cr2();
}

static inline void write_cr2(unsigned long x)
{
native_write_cr2(x);
}

static inline unsigned long read_cr3(void)
{
return native_read_cr3();
}

static inline void write_cr3(unsigned long x)
{
native_write_cr3(x);
}

static inline unsigned long read_cr4(void)
{
return native_read_cr4();
}

static inline unsigned long read_cr4_safe(void)
{
return native_read_cr4_safe();
}

static inline void write_cr4(unsigned long x)
{
native_write_cr4(x);
}

static inline void wbinvd(void)
{
native_wbinvd();
}

#ifdef CONFIG_X86_64
#define read_cr8() (native_read_cr8())
#define write_cr8(x) (native_write_cr8(x))
#define load_gs_index native_load_gs_index

static inline unsigned long read_cr8(void)
{
return native_read_cr8();
}

static inline void write_cr8(unsigned long x)
{
native_write_cr8(x);
}

static inline void load_gs_index(unsigned selector)
{
native_load_gs_index(selector);
}

#endif

/* Clear the 'TS' bit */
#define clts() (native_clts())
static inline void clts(void)
{
native_clts();
}

#endif/* CONFIG_PARAVIRT */

Expand Down

0 comments on commit 15d6aba

Please sign in to comment.