Skip to content

Commit

Permalink
media: v4l2-fwnode: Add a convenience function for registering subdev…
Browse files Browse the repository at this point in the history
…s with notifiers

Adds v4l2_async_register_fwnode_subdev(), which is a convenience function
for parsing a sub-device's fwnode port endpoints for connected remote
sub-devices, registering a sub-device notifier, and then registering
the sub-device itself.

Signed-off-by: Steve Longerbeam <slongerbeam@gmail.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
  • Loading branch information
Steve Longerbeam authored and Mauro Carvalho Chehab committed Oct 4, 2018
1 parent eae2aed commit 1634f0e
Show file tree
Hide file tree
Showing 2 changed files with 102 additions and 0 deletions.
64 changes: 64 additions & 0 deletions drivers/media/v4l2-core/v4l2-fwnode.c
Original file line number Diff line number Diff line change
Expand Up @@ -876,6 +876,70 @@ int v4l2_async_register_subdev_sensor_common(struct v4l2_subdev *sd)
}
EXPORT_SYMBOL_GPL(v4l2_async_register_subdev_sensor_common);

int v4l2_async_register_fwnode_subdev(
struct v4l2_subdev *sd, size_t asd_struct_size,
unsigned int *ports, unsigned int num_ports,
int (*parse_endpoint)(struct device *dev,
struct v4l2_fwnode_endpoint *vep,
struct v4l2_async_subdev *asd))
{
struct v4l2_async_notifier *notifier;
struct device *dev = sd->dev;
struct fwnode_handle *fwnode;
int ret;

if (WARN_ON(!dev))
return -ENODEV;

fwnode = dev_fwnode(dev);
if (!fwnode_device_is_available(fwnode))
return -ENODEV;

notifier = kzalloc(sizeof(*notifier), GFP_KERNEL);
if (!notifier)
return -ENOMEM;

v4l2_async_notifier_init(notifier);

if (!ports) {
ret = v4l2_async_notifier_parse_fwnode_endpoints(
dev, notifier, asd_struct_size, parse_endpoint);
if (ret < 0)
goto out_cleanup;
} else {
unsigned int i;

for (i = 0; i < num_ports; i++) {
ret = v4l2_async_notifier_parse_fwnode_endpoints_by_port(
dev, notifier, asd_struct_size,
ports[i], parse_endpoint);
if (ret < 0)
goto out_cleanup;
}
}

ret = v4l2_async_subdev_notifier_register(sd, notifier);
if (ret < 0)
goto out_cleanup;

ret = v4l2_async_register_subdev(sd);
if (ret < 0)
goto out_unregister;

sd->subdev_notifier = notifier;

return 0;

out_unregister:
v4l2_async_notifier_unregister(notifier);
out_cleanup:
v4l2_async_notifier_cleanup(notifier);
kfree(notifier);

return ret;
}
EXPORT_SYMBOL_GPL(v4l2_async_register_fwnode_subdev);

MODULE_LICENSE("GPL");
MODULE_AUTHOR("Sakari Ailus <sakari.ailus@linux.intel.com>");
MODULE_AUTHOR("Sylwester Nawrocki <s.nawrocki@samsung.com>");
Expand Down
38 changes: 38 additions & 0 deletions include/media/v4l2-fwnode.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#include <linux/types.h>

#include <media/v4l2-mediabus.h>
#include <media/v4l2-subdev.h>

struct fwnode_handle;
struct v4l2_async_notifier;
Expand Down Expand Up @@ -360,4 +361,41 @@ int v4l2_async_notifier_parse_fwnode_endpoints_by_port(
int v4l2_async_notifier_parse_fwnode_sensor_common(
struct device *dev, struct v4l2_async_notifier *notifier);

/**
* v4l2_async_register_fwnode_subdev - registers a sub-device to the
* asynchronous sub-device framework
* and parses fwnode endpoints
*
* @sd: pointer to struct &v4l2_subdev
* @asd_struct_size: size of the driver's async sub-device struct, including
* sizeof(struct v4l2_async_subdev). The &struct
* v4l2_async_subdev shall be the first member of
* the driver's async sub-device struct, i.e. both
* begin at the same memory address.
* @ports: array of port id's to parse for fwnode endpoints. If NULL, will
* parse all ports owned by the sub-device.
* @num_ports: number of ports in @ports array. Ignored if @ports is NULL.
* @parse_endpoint: Driver's callback function called on each V4L2 fwnode
* endpoint. Optional.
*
* This function is just like v4l2_async_register_subdev() with the
* exception that calling it will also allocate a notifier for the
* sub-device, parse the sub-device's firmware node endpoints using
* v4l2_async_notifier_parse_fwnode_endpoints() or
* v4l2_async_notifier_parse_fwnode_endpoints_by_port(), and
* registers the sub-device notifier. The sub-device is similarly
* unregistered by calling v4l2_async_unregister_subdev().
*
* While registered, the subdev module is marked as in-use.
*
* An error is returned if the module is no longer loaded on any attempts
* to register it.
*/
int v4l2_async_register_fwnode_subdev(
struct v4l2_subdev *sd, size_t asd_struct_size,
unsigned int *ports, unsigned int num_ports,
int (*parse_endpoint)(struct device *dev,
struct v4l2_fwnode_endpoint *vep,
struct v4l2_async_subdev *asd));

#endif /* _V4L2_FWNODE_H */

0 comments on commit 1634f0e

Please sign in to comment.