Skip to content

Commit

Permalink
ASoC: loongson: change the type of variable irq to int
Browse files Browse the repository at this point in the history
We use variable 'irq' to store the return value of fwnode_get_irq_byname().
A negative value indicates that the operation failed. If the type of 'irq'
is unsigned int, we never know if the operation failed.

Reported-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Closes: https://lore.kernel.org/loongarch/325dd825-6fa5-0ebc-4b7e-7acf2d2840e4@loongson.cn/
Signed-off-by: YingKun Meng <mengyingkun@loongson.cn>
Link: https://lore.kernel.org/r/20230619074649.3608726-1-mengyingkun@loongson.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
YingKun Meng authored and Mark Brown committed Jun 19, 2023
1 parent 3e4ecd6 commit 1650e8a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/soc/loongson/loongson_i2s.h
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
struct loongson_dma_data {
dma_addr_t dev_addr; /* device physical address for DMA */
void __iomem *order_addr; /* DMA order register */
u32 irq; /* DMA irq */
int irq; /* DMA irq */
};

struct loongson_i2s {
Expand Down

0 comments on commit 1650e8a

Please sign in to comment.