Skip to content

Commit

Permalink
x86: Be consistent with data size in getuser.S
Browse files Browse the repository at this point in the history
Consistently use the data register by name and use a sized assembly
instruction in getuser.S.  There is never any reason to macroize it,
and being inconsistent in the same file is just annoying.

No actual code change.

Signed-off-by: H. Peter Anvin <hpa@zytor.com>
  • Loading branch information
H. Peter Anvin committed Feb 12, 2013
1 parent b390784 commit 1664016
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions arch/x86/lib/getuser.S
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ ENTRY(__get_user_1)
cmp TI_addr_limit(%_ASM_DX),%_ASM_AX
jae bad_get_user
ASM_STAC
1: movzb (%_ASM_AX),%edx
1: movzbl (%_ASM_AX),%edx
xor %eax,%eax
ASM_CLAC
ret
Expand Down Expand Up @@ -71,7 +71,7 @@ ENTRY(__get_user_4)
cmp TI_addr_limit(%_ASM_DX),%_ASM_AX
jae bad_get_user
ASM_STAC
3: mov -3(%_ASM_AX),%edx
3: movl -3(%_ASM_AX),%edx
xor %eax,%eax
ASM_CLAC
ret
Expand All @@ -87,7 +87,7 @@ ENTRY(__get_user_8)
cmp TI_addr_limit(%_ASM_DX),%_ASM_AX
jae bad_get_user
ASM_STAC
4: movq -7(%_ASM_AX),%_ASM_DX
4: movq -7(%_ASM_AX),%rdx
xor %eax,%eax
ASM_CLAC
ret
Expand All @@ -98,8 +98,8 @@ ENTRY(__get_user_8)
cmp TI_addr_limit(%_ASM_DX),%_ASM_AX
jae bad_get_user_8
ASM_STAC
4: mov -7(%_ASM_AX),%edx
5: mov -3(%_ASM_AX),%ecx
4: movl -7(%_ASM_AX),%edx
5: movl -3(%_ASM_AX),%ecx
xor %eax,%eax
ASM_CLAC
ret
Expand Down

0 comments on commit 1664016

Please sign in to comment.