Skip to content

Commit

Permalink
dt-bindings: interconnect: Exclude all non msm8939 from snoc-mm
Browse files Browse the repository at this point in the history
New properties should be defined before the allOf. Move the
patternProperties definition to before the additionalProperties: false in
this file.

Exclude all non msm8939 compats from containing a matching
patternProperties.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Link: https://lore.kernel.org/r/20230123023127.1186619-3-bryan.odonoghue@linaro.org
Signed-off-by: Georgi Djakov <djakov@kernel.org>
  • Loading branch information
Bryan O'Donoghue authored and Georgi Djakov committed Jan 30, 2023
1 parent 62a4545 commit 16700ac
Showing 1 changed file with 42 additions and 31 deletions.
73 changes: 42 additions & 31 deletions Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,37 @@ properties:
power-domains:
maxItems: 1

# Child node's properties
patternProperties:
'^interconnect-[a-z0-9]+$':
type: object
description:
snoc-mm is a child of snoc, sharing snoc's register address space.

properties:
compatible:
enum:
- qcom,msm8939-snoc-mm

'#interconnect-cells':
const: 1

clock-names:
items:
- const: bus
- const: bus_a

clocks:
items:
- description: Bus Clock
- description: Bus A Clock

required:
- compatible
- '#interconnect-cells'
- clock-names
- clocks

required:
- compatible
- reg
Expand Down Expand Up @@ -109,37 +140,6 @@ allOf:
- description: Bus Clock
- description: Bus A Clock

# Child node's properties
patternProperties:
'^interconnect-[a-z0-9]+$':
type: object
description:
snoc-mm is a child of snoc, sharing snoc's register address space.

properties:
compatible:
enum:
- qcom,msm8939-snoc-mm

'#interconnect-cells':
const: 1

clock-names:
items:
- const: bus
- const: bus_a

clocks:
items:
- description: Bus Clock
- description: Bus A Clock

required:
- compatible
- '#interconnect-cells'
- clock-names
- clocks

- if:
properties:
compatible:
Expand Down Expand Up @@ -215,6 +215,17 @@ allOf:
- description: Aggregate2 USB3 AXI Clock.
- description: Config NoC USB2 AXI Clock.

- if:
not:
properties:
compatible:
contains:
enum:
- qcom,msm8939-snoc
then:
patternProperties:
'^interconnect-[a-z0-9]+$': false

examples:
- |
#include <dt-bindings/clock/qcom,rpmcc.h>
Expand Down

0 comments on commit 16700ac

Please sign in to comment.