Skip to content

Commit

Permalink
spi: Add a timeout when waiting for transfers
Browse files Browse the repository at this point in the history
Don't wait indefinitely for transfers to complete but time out after 10ms
more than we expect the transfer to take on the wire.

Signed-off-by: Mark Brown <broonie@linaro.org>
  • Loading branch information
Mark Brown committed Feb 3, 2014
1 parent 38dbfb5 commit 16a0ce4
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion drivers/spi/spi.c
Original file line number Diff line number Diff line change
Expand Up @@ -594,6 +594,7 @@ static int spi_transfer_one_message(struct spi_master *master,
bool cur_cs = true;
bool keep_cs = false;
int ret = 0;
int ms = 1;

spi_set_cs(msg->spi, true);

Expand All @@ -611,7 +612,16 @@ static int spi_transfer_one_message(struct spi_master *master,

if (ret > 0) {
ret = 0;
wait_for_completion(&master->xfer_completion);
ms = xfer->len * 8 * 1000 / xfer->speed_hz;
ms += 10; /* some tolerance */

ms = wait_for_completion_timeout(&master->xfer_completion,
msecs_to_jiffies(ms));
}

if (ms == 0) {
dev_err(&msg->spi->dev, "SPI transfer timed out\n");
msg->status = -ETIMEDOUT;
}

trace_spi_transfer_stop(msg, xfer);
Expand Down

0 comments on commit 16a0ce4

Please sign in to comment.