Skip to content

Commit

Permalink
serial: Fix crash if the minimum rate of the device is > 9600 baud
Browse files Browse the repository at this point in the history
In that situation if the old rate is invalid and the new rate is invalid
and the chip cannot do 9600 baud we report zero, which makes all the
drivers explode.

Instead force the rate based on min/max

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Alan Cox authored and Greg Kroah-Hartman committed Jan 20, 2010
1 parent 4547be7 commit 16ae2a8
Showing 1 changed file with 12 additions and 5 deletions.
17 changes: 12 additions & 5 deletions drivers/serial/serial_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -385,13 +385,20 @@ uart_get_baud_rate(struct uart_port *port, struct ktermios *termios,
}

/*
* As a last resort, if the quotient is zero,
* default to 9600 bps
* As a last resort, if the range cannot be met then clip to
* the nearest chip supported rate.
*/
if (!hung_up)
tty_termios_encode_baud_rate(termios, 9600, 9600);
if (!hung_up) {
if (baud <= min)
tty_termios_encode_baud_rate(termios,
min + 1, min + 1);
else
tty_termios_encode_baud_rate(termios,
max - 1, max - 1);
}
}

/* Should never happen */
WARN_ON(1);
return 0;
}

Expand Down

0 comments on commit 16ae2a8

Please sign in to comment.