Skip to content

Commit

Permalink
cpufreq: governor: Simplify performance and powersave governors
Browse files Browse the repository at this point in the history
The performance and powersave cpufreq governors handle the
CPUFREQ_GOV_START event in the same way as CPUFREQ_GOV_LIMITS.
However, the cpufreq core always invokes cpufreq_governor() with the
event argument equal to CPUFREQ_GOV_LIMITS right after invoking it with
event equal to CPUFREQ_GOV_START.  As a result, for both the governors
in question, __cpufreq_driver_target() is executed twice in a row
with the same arguments which is not useful.

For this reason, simplify the performance and powersave governors
to handle the CPUFREQ_GOV_LIMITS event only as that's going to be
sufficient for the governor start too.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
  • Loading branch information
Rafael J. Wysocki committed May 30, 2016
1 parent 9e8c0a8 commit 16de72b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
4 changes: 1 addition & 3 deletions drivers/cpufreq/cpufreq_performance.c
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,8 @@ static int cpufreq_governor_performance(struct cpufreq_policy *policy,
unsigned int event)
{
switch (event) {
case CPUFREQ_GOV_START:
case CPUFREQ_GOV_LIMITS:
pr_debug("setting to %u kHz because of event %u\n",
policy->max, event);
pr_debug("setting to %u kHz\n", policy->max);
__cpufreq_driver_target(policy, policy->max,
CPUFREQ_RELATION_H);
break;
Expand Down
4 changes: 1 addition & 3 deletions drivers/cpufreq/cpufreq_powersave.c
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,8 @@ static int cpufreq_governor_powersave(struct cpufreq_policy *policy,
unsigned int event)
{
switch (event) {
case CPUFREQ_GOV_START:
case CPUFREQ_GOV_LIMITS:
pr_debug("setting to %u kHz because of event %u\n",
policy->min, event);
pr_debug("setting to %u kHz\n", policy->min);
__cpufreq_driver_target(policy, policy->min,
CPUFREQ_RELATION_L);
break;
Expand Down

0 comments on commit 16de72b

Please sign in to comment.