Skip to content

Commit

Permalink
clocksource/drivers/tango-xtal: Fix boot hang due to incorrect test
Browse files Browse the repository at this point in the history
Commit 0881841 introduced a regression by inverting a test check
after calling clocksource_mmio_init(). That results on the system to
hang at boot time.

Fix it by inverting the test again.

Fixes: 0881841 ("Replace code by clocksource_mmio_init")
Reported-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
  • Loading branch information
Daniel Lezcano committed Apr 22, 2016
1 parent b7c8b4a commit 16eeed7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/clocksource/tango_xtal.c
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ static void __init tango_clocksource_init(struct device_node *np)

ret = clocksource_mmio_init(xtal_in_cnt, "tango-xtal", xtal_freq, 350,
32, clocksource_mmio_readl_up);
if (!ret) {
if (ret) {
pr_err("%s: registration failed\n", np->full_name);
return;
}
Expand Down

0 comments on commit 16eeed7

Please sign in to comment.