Skip to content

Commit

Permalink
rbd: delete an unnecessary check before rbd_dev_destroy()
Browse files Browse the repository at this point in the history
The rbd_dev_destroy() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
  • Loading branch information
Markus Elfring authored and Ilya Dryomov committed Jan 21, 2016
1 parent 17ddc49 commit 1761b22
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/block/rbd.c
Original file line number Diff line number Diff line change
Expand Up @@ -5185,8 +5185,7 @@ static int rbd_dev_probe_parent(struct rbd_device *rbd_dev, int depth)

out_err:
rbd_dev_unparent(rbd_dev);
if (parent)
rbd_dev_destroy(parent);
rbd_dev_destroy(parent);
return ret;
}

Expand Down

0 comments on commit 1761b22

Please sign in to comment.