Skip to content

Commit

Permalink
x86: fix up alternatives with lockdep enabled
Browse files Browse the repository at this point in the history
An older binutils bug caused us to not fix up alternatives.
This problem involved mutex.c but we dont do lockdep section tricks
there anymore, so this workaround is moot. Keep the printk nevertheless,
just in case ... We can remove that later on.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Ingo Molnar committed Jan 30, 2008
1 parent ad8ca49 commit 17abecf
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions arch/x86/kernel/alternative.c
Original file line number Diff line number Diff line change
Expand Up @@ -342,12 +342,13 @@ void alternatives_smp_switch(int smp)

#ifdef CONFIG_LOCKDEP
/*
* A not yet fixed binutils section handling bug prevents
* alternatives-replacement from working reliably, so turn
* it off:
* Older binutils section handling bug prevented
* alternatives-replacement from working reliably.
*
* If this still occurs then you should see a hang
* or crash shortly after this line:
*/
printk("lockdep: not fixing up alternatives.\n");
return;
printk("lockdep: fixing up alternatives.\n");
#endif

if (noreplace_smp || smp_alt_once)
Expand Down

0 comments on commit 17abecf

Please sign in to comment.