Skip to content

Commit

Permalink
bna: use container_of to resolve bufdesc_ex from bufdesc
Browse files Browse the repository at this point in the history
Use container_of instead of casting first structure member.

Compiled but untested.

Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Fabian Frederick authored and David S. Miller committed Sep 15, 2014
1 parent 61cd2eb commit 17b6f24
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
9 changes: 6 additions & 3 deletions drivers/net/ethernet/brocade/bna/bna_enet.c
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,8 @@ bna_bfi_ethport_admin_rsp(struct bna_ethport *ethport,
{
struct bfi_enet_enable_req *admin_req =
&ethport->bfi_enet_cmd.admin_req;
struct bfi_enet_rsp *rsp = (struct bfi_enet_rsp *)msghdr;
struct bfi_enet_rsp *rsp =
container_of(msghdr, struct bfi_enet_rsp, mh);

switch (admin_req->enable) {
case BNA_STATUS_T_ENABLED:
Expand All @@ -133,7 +134,8 @@ bna_bfi_ethport_lpbk_rsp(struct bna_ethport *ethport,
{
struct bfi_enet_diag_lb_req *diag_lb_req =
&ethport->bfi_enet_cmd.lpbk_req;
struct bfi_enet_rsp *rsp = (struct bfi_enet_rsp *)msghdr;
struct bfi_enet_rsp *rsp =
container_of(msghdr, struct bfi_enet_rsp, mh);

switch (diag_lb_req->enable) {
case BNA_STATUS_T_ENABLED:
Expand Down Expand Up @@ -161,7 +163,8 @@ static void
bna_bfi_attr_get_rsp(struct bna_ioceth *ioceth,
struct bfi_msgq_mhdr *msghdr)
{
struct bfi_enet_attr_rsp *rsp = (struct bfi_enet_attr_rsp *)msghdr;
struct bfi_enet_attr_rsp *rsp =
container_of(msghdr, struct bfi_enet_attr_rsp, mh);

/**
* Store only if not set earlier, since BNAD can override the HW
Expand Down
4 changes: 2 additions & 2 deletions drivers/net/ethernet/brocade/bna/bna_tx_rx.c
Original file line number Diff line number Diff line change
Expand Up @@ -715,7 +715,7 @@ bna_bfi_rxf_ucast_set_rsp(struct bna_rxf *rxf,
struct bfi_msgq_mhdr *msghdr)
{
struct bfi_enet_rsp *rsp =
(struct bfi_enet_rsp *)msghdr;
container_of(msghdr, struct bfi_enet_rsp, mh);

if (rsp->error) {
/* Clear ucast from cache */
Expand All @@ -732,7 +732,7 @@ bna_bfi_rxf_mcast_add_rsp(struct bna_rxf *rxf,
struct bfi_enet_mcast_add_req *req =
&rxf->bfi_enet_cmd.mcast_add_req;
struct bfi_enet_mcast_add_rsp *rsp =
(struct bfi_enet_mcast_add_rsp *)msghdr;
container_of(msghdr, struct bfi_enet_mcast_add_rsp, mh);

bna_rxf_mchandle_attach(rxf, (u8 *)&req->mac_addr,
ntohs(rsp->handle));
Expand Down

0 comments on commit 17b6f24

Please sign in to comment.