Skip to content

Commit

Permalink
ice: Move vector base setup to PF VSI
Browse files Browse the repository at this point in the history
When interrupt tracking was refactored, during rebuild, the call to
ice_vsi_setup_vector_base() was inadvertently removed from the PF VSI
instead of being removed from the VF VSI. During reset, the failure to
properly setup the vector base generates a call trace. Correct this so
that resets/rebuilds properly complete.

Fixes: cbe66bf ("ice: Refactor interrupt tracking")
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
  • Loading branch information
Tony Nguyen authored and Jeff Kirsher committed Jul 31, 2019
1 parent 36517fd commit 17bc6d0
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/net/ethernet/intel/ice/ice_lib.c
Original file line number Diff line number Diff line change
Expand Up @@ -2978,6 +2978,10 @@ int ice_vsi_rebuild(struct ice_vsi *vsi)
if (ret)
goto err_rings;

ret = ice_vsi_setup_vector_base(vsi);
if (ret)
goto err_vectors;

ret = ice_vsi_set_q_vectors_reg_idx(vsi);
if (ret)
goto err_vectors;
Expand All @@ -2999,10 +3003,6 @@ int ice_vsi_rebuild(struct ice_vsi *vsi)
if (ret)
goto err_rings;

ret = ice_vsi_setup_vector_base(vsi);
if (ret)
goto err_vectors;

ret = ice_vsi_set_q_vectors_reg_idx(vsi);
if (ret)
goto err_vectors;
Expand Down

0 comments on commit 17bc6d0

Please sign in to comment.