Skip to content

Commit

Permalink
USB: ehci-platform: Display a DMA configuration error message
Browse files Browse the repository at this point in the history
If the ehci driver fails to configure the dma settings then display
a dev error instead of simply failing. This is triggered in an
ACPI world if the user fails to set the _CCA on the device.

Tested-by: Huang Shijie <shijie.huang@arm.com>
Reviewed-by: Graeme Gregory <graeme.gregory@linaro.org>
Reviewed-by: Hanjun Guo <hanjun.guo@linaro.org>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Jeremy Linton authored and Greg Kroah-Hartman committed Oct 4, 2015
1 parent 39047e0 commit 17f69b5
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/usb/host/ehci-platform.c
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,10 @@ static int ehci_platform_probe(struct platform_device *dev)

err = dma_coerce_mask_and_coherent(&dev->dev,
pdata->dma_mask_64 ? DMA_BIT_MASK(64) : DMA_BIT_MASK(32));
if (err)
if (err) {
dev_err(&dev->dev, "Error: DMA mask configuration failed\n");
return err;
}

irq = platform_get_irq(dev, 0);
if (irq < 0) {
Expand Down

0 comments on commit 17f69b5

Please sign in to comment.