Skip to content

Commit

Permalink
spi: spi-geni-qcom: Print an error when we timeout setting the CS
Browse files Browse the repository at this point in the history
If we're using geni to manage the chip select line (don't do it--use a
GPIO!) and we happen to get a timeout waiting for the chip select
command to be completed, no errors are printed even though things
might not be in the best shape.  Let's add a print.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Link: https://lore.kernel.org/r/20201217142842.v3.4.I666b37646de9652cef438ac7c2c6c2053367fc6b@changeid
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Douglas Anderson authored and Mark Brown committed Dec 18, 2020
1 parent 3d7d916 commit 17fa81a
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/spi/spi-geni-qcom.c
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,10 @@ static void spi_geni_set_cs(struct spi_device *slv, bool set_flag)
spin_unlock_irq(&mas->lock);

time_left = wait_for_completion_timeout(&mas->cs_done, HZ);
if (!time_left)
if (!time_left) {
dev_warn(mas->dev, "Timeout setting chip select\n");
handle_fifo_timeout(spi, NULL);
}

exit:
pm_runtime_put(mas->dev);
Expand Down

0 comments on commit 17fa81a

Please sign in to comment.