Skip to content

Commit

Permalink
cgroup: return early if it is already on preloaded list
Browse files Browse the repository at this point in the history
If a cset is already on preloaded list, this means we have already setup
this cset properly for migration.

This patch just relocates the root cgrp lookup which isn't used anyway
when the cset is already on the preloaded list.

[tj@kernel.org: rephrase the commit log]

Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
  • Loading branch information
Wei Yang authored and Tejun Heo committed Dec 14, 2021
1 parent 1f1562f commit 1815775
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions kernel/cgroup/cgroup.c
Original file line number Diff line number Diff line change
Expand Up @@ -2650,11 +2650,11 @@ void cgroup_migrate_add_src(struct css_set *src_cset,
if (src_cset->dead)
return;

src_cgrp = cset_cgroup_from_root(src_cset, dst_cgrp->root);

if (!list_empty(&src_cset->mg_preload_node))
return;

src_cgrp = cset_cgroup_from_root(src_cset, dst_cgrp->root);

WARN_ON(src_cset->mg_src_cgrp);
WARN_ON(src_cset->mg_dst_cgrp);
WARN_ON(!list_empty(&src_cset->mg_tasks));
Expand Down

0 comments on commit 1815775

Please sign in to comment.