Skip to content

Commit

Permalink
configfs: replace strncpy with memcpy
Browse files Browse the repository at this point in the history
gcc 8.1.0 complains:

fs/configfs/symlink.c:67:3: warning:
	'strncpy' output truncated before terminating nul copying as many
	bytes from a string as its length
fs/configfs/symlink.c: In function 'configfs_get_link':
fs/configfs/symlink.c:63:13: note: length computed here

Using strncpy() is indeed less than perfect since the length of data to
be copied has already been determined with strlen(). Replace strncpy()
with memcpy() to address the warning and optimize the code a little.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Christoph Hellwig <hch@lst.de>
  • Loading branch information
Guenter Roeck authored and Christoph Hellwig committed Jul 2, 2018
1 parent 707c623 commit 1823342
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/configfs/symlink.c
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ static void fill_item_path(struct config_item * item, char * buffer, int length)

/* back up enough to print this bus id with '/' */
length -= cur;
strncpy(buffer + length,config_item_name(p),cur);
memcpy(buffer + length, config_item_name(p), cur);
*(buffer + --length) = '/';
}
}
Expand Down

0 comments on commit 1823342

Please sign in to comment.