Skip to content

Commit

Permalink
net: ena: change the return type of ena_set_push_mode() to be void.
Browse files Browse the repository at this point in the history
This patch changes the return type of ena_set_push_mode() to be void,
as it always returns 0.

Signed-off-by: Rami Rosen <ramirose@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Rami Rosen authored and David S. Miller committed Aug 24, 2016
1 parent 85d2c92 commit 184b49c
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions drivers/net/ethernet/amazon/ena/ena_netdev.c
Original file line number Diff line number Diff line change
Expand Up @@ -2681,8 +2681,8 @@ static int ena_calc_io_queue_num(struct pci_dev *pdev,
return io_queue_num;
}

static int ena_set_push_mode(struct pci_dev *pdev, struct ena_com_dev *ena_dev,
struct ena_com_dev_get_features_ctx *get_feat_ctx)
static void ena_set_push_mode(struct pci_dev *pdev, struct ena_com_dev *ena_dev,
struct ena_com_dev_get_features_ctx *get_feat_ctx)
{
bool has_mem_bar;

Expand All @@ -2693,8 +2693,6 @@ static int ena_set_push_mode(struct pci_dev *pdev, struct ena_com_dev *ena_dev,
ena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_DEV;
else
ena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_HOST;

return 0;
}

static void ena_set_dev_offloads(struct ena_com_dev_get_features_ctx *feat,
Expand Down Expand Up @@ -2913,11 +2911,7 @@ static int ena_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
goto err_free_region;
}

rc = ena_set_push_mode(pdev, ena_dev, &get_feat_ctx);
if (rc) {
dev_err(&pdev->dev, "Invalid module param(push_mode)\n");
goto err_device_destroy;
}
ena_set_push_mode(pdev, ena_dev, &get_feat_ctx);

if (ena_dev->tx_mem_queue_type == ENA_ADMIN_PLACEMENT_POLICY_DEV) {
ena_dev->mem_bar = ioremap_wc(pci_resource_start(pdev, ENA_MEM_BAR),
Expand Down

0 comments on commit 184b49c

Please sign in to comment.