Skip to content

Commit

Permalink
Staging: rtl8192e: Drop unnecessary NULL test
Browse files Browse the repository at this point in the history
The result of container_of should not be NULL.  In particular, in this case
the argument to the enclosing function has passed though INIT_WORK, which
dereferences it, implying that its container cannot be NULL.

A simplified version of the semantic patch that makes this change is as
follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
identifier fn,work,x,fld;
type T;
expression E1,E2;
statement S;
@@

static fn(struct work_struct *work) {
  ... when != work = E1
  x = container_of(work,T,fld)
  ... when != x = E2
- if (x == NULL) S
  ...
}
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Julia Lawall authored and Greg Kroah-Hartman committed Sep 15, 2009
1 parent c07d3c7 commit 18526c7
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/staging/rtl8192e/r8192E_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1763,8 +1763,6 @@ static void rtl8192_qos_activate(struct work_struct * work)
u8 u1bAIFS;
u32 u4bAcParam;
int i;
if (priv == NULL)
return;

mutex_lock(&priv->mutex);
if(priv->ieee80211->state != IEEE80211_LINKED)
Expand Down

0 comments on commit 18526c7

Please sign in to comment.