Skip to content

Commit

Permalink
perf sort: Remove needless headers from sort.h, provide fwd struct decls
Browse files Browse the repository at this point in the history
Reducing the includes hell a bit more, speeding up the build and
avoiding needless rebuilds when just one of those files gets updated.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lkml.kernel.org/n/tip-u63el2vqsovsmnhebx1rcixo@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Arnaldo Carvalho de Melo committed Aug 26, 2019
1 parent 97b9d86 commit 185bcb9
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 13 deletions.
2 changes: 2 additions & 0 deletions tools/perf/ui/browsers/res_sample.c
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
#include "sort.h"
#include "config.h"
#include "time-utils.h"
#include "../util.h"
#include "../../util/util.h"
#include <linux/time64.h>
#include <linux/zalloc.h>

Expand Down
2 changes: 2 additions & 0 deletions tools/perf/ui/browsers/scripts.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
#include "../../builtin.h"
#include "../../util/sort.h"
#include "../../util/util.h"
#include "../../util/hist.h"
#include "../../util/debug.h"
#include "../../util/symbol.h"
Expand Down
1 change: 1 addition & 0 deletions tools/perf/ui/stdio/hist.c
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#include <linux/string.h>

#include "../../util/callchain.h"
#include "../../util/debug.h"
#include "../../util/hist.h"
#include "../../util/map.h"
#include "../../util/map_groups.h"
Expand Down
1 change: 1 addition & 0 deletions tools/perf/util/callchain.c
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

#include "asm/bug.h"

#include "debug.h"
#include "hist.h"
#include "sort.h"
#include "machine.h"
Expand Down
15 changes: 2 additions & 13 deletions tools/perf/util/sort.h
Original file line number Diff line number Diff line change
@@ -1,29 +1,18 @@
/* SPDX-License-Identifier: GPL-2.0 */
#ifndef __PERF_SORT_H
#define __PERF_SORT_H
#include "../builtin.h"

#include <regex.h>

#include "color.h"
#include <stdbool.h>
#include <linux/list.h>
#include "cache.h"
#include <linux/rbtree.h>
#include "map_symbol.h"
#include "symbol_conf.h"
#include "string.h"
#include "callchain.h"
#include "values.h"

#include "../perf.h"
#include "debug.h"
#include "header.h"

#include <subcmd/parse-options.h>
#include "parse-events.h"
#include "hist.h"
#include "srcline.h"

struct option;
struct thread;

extern regex_t parent_regex;
Expand Down

0 comments on commit 185bcb9

Please sign in to comment.