Skip to content

Commit

Permalink
openvswitch: Pass net into ovs_vport_output
Browse files Browse the repository at this point in the history
When struct net starts being passed through the ipv4 and ipv6 fragment
routines ovs_vport_output will need to take a net parameter.
Prepare ovs_vport_output before that is needed and introduce
ovs_vport_output_skk for the call sites that still need the old
calling conventions.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
  • Loading branch information
Eric W. Biederman committed Sep 30, 2015
1 parent 4bf1b54 commit 188515f
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions net/openvswitch/actions.c
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,7 @@ static int set_sctp(struct sk_buff *skb, struct sw_flow_key *flow_key,
return 0;
}

static int ovs_vport_output(struct sock *sock, struct sk_buff *skb)
static int ovs_vport_output(struct net *net, struct sock *sk, struct sk_buff *skb)
{
struct ovs_frag_data *data = this_cpu_ptr(&ovs_frag_data_storage);
struct vport *vport = data->vport;
Expand All @@ -645,6 +645,11 @@ static int ovs_vport_output(struct sock *sock, struct sk_buff *skb)
ovs_vport_send(vport, skb);
return 0;
}
static int ovs_vport_output_sk(struct sock *sk, struct sk_buff *skb)
{
struct net *net = dev_net(skb_dst(skb)->dev);
return ovs_vport_output(net, sk, skb);
}

static unsigned int
ovs_dst_get_mtu(const struct dst_entry *dst)
Expand Down Expand Up @@ -700,7 +705,7 @@ static void ovs_fragment(struct vport *vport, struct sk_buff *skb, u16 mru,
skb_dst_set_noref(skb, &ovs_dst);
IPCB(skb)->frag_max_size = mru;

ip_do_fragment(skb->sk, skb, ovs_vport_output);
ip_do_fragment(skb->sk, skb, ovs_vport_output_sk);
refdst_drop(orig_dst);
} else if (ethertype == htons(ETH_P_IPV6)) {
const struct nf_ipv6_ops *v6ops = nf_get_ipv6_ops();
Expand All @@ -722,7 +727,7 @@ static void ovs_fragment(struct vport *vport, struct sk_buff *skb, u16 mru,
skb_dst_set_noref(skb, &ovs_rt.dst);
IP6CB(skb)->frag_max_size = mru;

v6ops->fragment(skb->sk, skb, ovs_vport_output);
v6ops->fragment(skb->sk, skb, ovs_vport_output_sk);
refdst_drop(orig_dst);
} else {
WARN_ONCE(1, "Failed fragment ->%s: eth=%04x, MRU=%d, MTU=%d.",
Expand Down

0 comments on commit 188515f

Please sign in to comment.