Skip to content

Commit

Permalink
rtnl/do_setlink(): set modified when IFLA_LINKMODE is updated
Browse files Browse the repository at this point in the history
The only effect of this patch is to print a warning if IFLA_LINKMODE is updated
and a following change fails.

Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Nicolas Dichtel authored and David S. Miller committed Sep 2, 2014
1 parent 5d1180f commit 1889b0e
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion net/core/rtnetlink.c
Original file line number Diff line number Diff line change
Expand Up @@ -1624,8 +1624,12 @@ static int do_setlink(const struct sk_buff *skb,
set_operstate(dev, nla_get_u8(tb[IFLA_OPERSTATE]));

if (tb[IFLA_LINKMODE]) {
unsigned char value = nla_get_u8(tb[IFLA_LINKMODE]);

write_lock_bh(&dev_base_lock);
dev->link_mode = nla_get_u8(tb[IFLA_LINKMODE]);
if (dev->link_mode ^ value)
modified = 1;
dev->link_mode = value;
write_unlock_bh(&dev_base_lock);
}

Expand Down

0 comments on commit 1889b0e

Please sign in to comment.