Skip to content

Commit

Permalink
Phonet: error on broadcast sending (unimplemented)
Browse files Browse the repository at this point in the history
If we ever implement this, then we can stop returning an error.

Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Rémi Denis-Courmont authored and David S. Miller committed Sep 24, 2009
1 parent 582b0b6 commit 18a1166
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions include/linux/phonet.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
#define PNPIPE_IFINDEX 2

#define PNADDR_ANY 0
#define PNADDR_BROADCAST 0xFC
#define PNPORT_RESOURCE_ROUTING 0

/* Values for PNPIPE_ENCAP option */
Expand Down
6 changes: 6 additions & 0 deletions net/phonet/af_phonet.c
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,12 @@ static int pn_send(struct sk_buff *skb, struct net_device *dev,
goto drop;
}

/* Broadcast sending is not implemented */
if (pn_addr(dst) == PNADDR_BROADCAST) {
err = -EOPNOTSUPP;
goto drop;
}

skb_reset_transport_header(skb);
WARN_ON(skb_headroom(skb) & 1); /* HW assumes word alignment */
skb_push(skb, sizeof(struct phonethdr));
Expand Down

0 comments on commit 18a1166

Please sign in to comment.