Skip to content

Commit

Permalink
mm: page-writeback.c: local functions should not be exposed globally
Browse files Browse the repository at this point in the history
The function global_dirtyable_memory is only referenced in this file and
should be marked static to prevent it from being exposed globally.

This quiets the sparse warning:

warning: symbol 'global_dirtyable_memory' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
  • Loading branch information
H Hartley Sweeten authored and Fengguang Wu committed Apr 14, 2012
1 parent 668ce0a commit 18cf8cf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion mm/page-writeback.c
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ static unsigned long highmem_dirtyable_memory(unsigned long total)
* Returns the global number of pages potentially available for dirty
* page cache. This is the base value for the global dirty limits.
*/
unsigned long global_dirtyable_memory(void)
static unsigned long global_dirtyable_memory(void)
{
unsigned long x;

Expand Down

0 comments on commit 18cf8cf

Please sign in to comment.