Skip to content

Commit

Permalink
ASoC: mt8183: Fix event generation for I2S DAI operations
Browse files Browse the repository at this point in the history
ALSA control put() operations should return 0 if the value changed so that
events can be generated appropriately for userspace but the custom control
in the MT8183 I2S DAI driver doesn't do that, fix it.

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20230224-asoc-mt8183-quick-fixes-v1-2-041f29419ed5@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Mark Brown committed Feb 28, 2023
1 parent d71ed1c commit 18f51ed
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions sound/soc/mediatek/mt8183/mt8183-dai-i2s.c
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ static int mt8183_i2s_hd_set(struct snd_kcontrol *kcontrol,
struct mtk_base_afe *afe = snd_soc_component_get_drvdata(cmpnt);
struct mtk_afe_i2s_priv *i2s_priv;
struct soc_enum *e = (struct soc_enum *)kcontrol->private_value;
int hd_en;
int hd_en, change;

if (ucontrol->value.enumerated.item[0] >= e->items)
return -EINVAL;
Expand All @@ -155,9 +155,10 @@ static int mt8183_i2s_hd_set(struct snd_kcontrol *kcontrol,
return -EINVAL;
}

change = i2s_priv->low_jitter_en != hd_en;
i2s_priv->low_jitter_en = hd_en;

return 0;
return change;
}

static const struct snd_kcontrol_new mtk_dai_i2s_controls[] = {
Expand Down

0 comments on commit 18f51ed

Please sign in to comment.