Skip to content

Commit

Permalink
iio: light: lm3533-als: Print error message on invalid resistance
Browse files Browse the repository at this point in the history
Print an error message to indicate that invalid configuration data was
provided in the platform_data, rather than just aborting initialization.

Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
  • Loading branch information
Bjorn Andersson authored and Jonathan Cameron committed Oct 31, 2015
1 parent 2d6ca60 commit 18fb1ab
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/iio/light/lm3533-als.c
Original file line number Diff line number Diff line change
Expand Up @@ -743,8 +743,10 @@ static int lm3533_als_set_resistor(struct lm3533_als *als, u8 val)
{
int ret;

if (val < LM3533_ALS_RESISTOR_MIN || val > LM3533_ALS_RESISTOR_MAX)
if (val < LM3533_ALS_RESISTOR_MIN || val > LM3533_ALS_RESISTOR_MAX) {
dev_err(&als->pdev->dev, "invalid resistor value\n");
return -EINVAL;
};

ret = lm3533_write(als->lm3533, LM3533_REG_ALS_RESISTOR_SELECT, val);
if (ret) {
Expand Down

0 comments on commit 18fb1ab

Please sign in to comment.