Skip to content

Commit

Permalink
drm/i915/selftests: Fix wrong return value of perf_request_latency()
Browse files Browse the repository at this point in the history
If intel context create failed, the perf_request_latency() will return 0
rather than error, because we doesn't initialize the return value.

Fixes: 25c26f1 ("drm/i915/selftests: Measure dispatch latency")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20201116143540.3648870-1-zhangxiaoxu5@huawei.com
  • Loading branch information
Zhang Xiaoxu authored and Chris Wilson committed Nov 16, 2020
1 parent 01d7088 commit 1938445
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/gpu/drm/i915/selftests/i915_request.c
Original file line number Diff line number Diff line change
Expand Up @@ -2293,8 +2293,10 @@ static int perf_request_latency(void *arg)
struct intel_context *ce;

ce = intel_context_create(engine);
if (IS_ERR(ce))
if (IS_ERR(ce)) {
err = PTR_ERR(ce);
goto out;
}

err = intel_context_pin(ce);
if (err) {
Expand Down

0 comments on commit 1938445

Please sign in to comment.