Skip to content

Commit

Permalink
nfc: st-nci: drop ftrace-like debugging messages
Browse files Browse the repository at this point in the history
Now that the kernel has ftrace, any debugging calls that just do "made
it to this function!" and "leaving this function!" can be removed.
Better to use standard debugging tools.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Link: https://lore.kernel.org/r/20210531073902.7111-6-krzysztof.kozlowski@canonical.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Krzysztof Kozlowski authored and Jakub Kicinski committed Jun 1, 2021
1 parent e83a264 commit 1952fa4
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 16 deletions.
5 changes: 0 additions & 5 deletions drivers/nfc/st-nci/i2c.c
Original file line number Diff line number Diff line change
Expand Up @@ -206,9 +206,6 @@ static int st_nci_i2c_probe(struct i2c_client *client,
struct st_nci_i2c_phy *phy;
int r;

dev_dbg(&client->dev, "%s\n", __func__);
dev_dbg(&client->dev, "IRQ: %d\n", client->irq);

if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
nfc_err(&client->dev, "Need I2C_FUNC_I2C\n");
return -ENODEV;
Expand Down Expand Up @@ -261,8 +258,6 @@ static int st_nci_i2c_remove(struct i2c_client *client)
{
struct st_nci_i2c_phy *phy = i2c_get_clientdata(client);

dev_dbg(&client->dev, "%s\n", __func__);

ndlc_remove(phy->ndlc);

return 0;
Expand Down
6 changes: 0 additions & 6 deletions drivers/nfc/st-nci/se.c
Original file line number Diff line number Diff line change
Expand Up @@ -470,8 +470,6 @@ int st_nci_disable_se(struct nci_dev *ndev, u32 se_idx)
{
int r;

pr_debug("st_nci_disable_se\n");

/*
* According to upper layer, se_idx == NFC_SE_UICC when
* info->se_info.se_status->is_uicc_enable is true should never happen
Expand All @@ -496,8 +494,6 @@ int st_nci_enable_se(struct nci_dev *ndev, u32 se_idx)
{
int r;

pr_debug("st_nci_enable_se\n");

/*
* According to upper layer, se_idx == NFC_SE_UICC when
* info->se_info.se_status->is_uicc_enable is true should never happen.
Expand Down Expand Up @@ -602,8 +598,6 @@ int st_nci_discover_se(struct nci_dev *ndev)
int se_count = 0;
struct st_nci_info *info = nci_get_drvdata(ndev);

pr_debug("st_nci_discover_se\n");

r = st_nci_hci_network_init(ndev);
if (r != 0)
return r;
Expand Down
5 changes: 0 additions & 5 deletions drivers/nfc/st-nci/spi.c
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,6 @@ static int st_nci_spi_probe(struct spi_device *dev)
struct st_nci_spi_phy *phy;
int r;

dev_dbg(&dev->dev, "%s\n", __func__);
dev_dbg(&dev->dev, "IRQ: %d\n", dev->irq);

/* Check SPI platform functionnalities */
if (!dev) {
pr_debug("%s: dev is NULL. Device is not accessible.\n",
Expand Down Expand Up @@ -274,8 +271,6 @@ static int st_nci_spi_remove(struct spi_device *dev)
{
struct st_nci_spi_phy *phy = spi_get_drvdata(dev);

dev_dbg(&dev->dev, "%s\n", __func__);

ndlc_remove(phy->ndlc);

return 0;
Expand Down

0 comments on commit 1952fa4

Please sign in to comment.