Skip to content

Commit

Permalink
i2c: qup: off by ones in qup_i2c_probe()
Browse files Browse the repository at this point in the history
These should ">= ARRAY_SIZE()" instead of "> ARRAY_SIZE()".

Fixes: 10c5a84 ('i2c: qup: New bus driver for the Qualcomm QUP I2C controller')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
  • Loading branch information
Dan Carpenter authored and Wolfram Sang committed Apr 3, 2014
1 parent 3428f01 commit 199c1df
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/i2c/busses/i2c-qup.c
Original file line number Diff line number Diff line change
@@ -633,12 +633,12 @@ static int qup_i2c_probe(struct platform_device *pdev)
* associated with each byte written/received
*/
size = QUP_OUTPUT_BLOCK_SIZE(io_mode);
if (size > ARRAY_SIZE(blk_sizes))
if (size >= ARRAY_SIZE(blk_sizes))
return -EIO;
qup->out_blk_sz = blk_sizes[size] / 2;

size = QUP_INPUT_BLOCK_SIZE(io_mode);
if (size > ARRAY_SIZE(blk_sizes))
if (size >= ARRAY_SIZE(blk_sizes))
return -EIO;
qup->in_blk_sz = blk_sizes[size] / 2;

0 comments on commit 199c1df

Please sign in to comment.