Skip to content

Commit

Permalink
serial: pch_uart: fix tty-kref leak in dma-rx path
Browse files Browse the repository at this point in the history
Fix tty_kref leak when tty_buffer_request room fails in dma-rx path.

Note that the tty ref isn't really needed anymore, but as the leak has
always been there, fixing it before removing should makes it easier to
backport the fix.

Cc: stable@vger.kernel.org
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Johan Hovold authored and Greg Kroah-Hartman committed Sep 17, 2013
1 parent fc0919c commit 19b85cf
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/tty/serial/pch_uart.c
Original file line number Diff line number Diff line change
Expand Up @@ -685,11 +685,12 @@ static int dma_push_rx(struct eg20t_port *priv, int size)
dev_warn(port->dev, "Rx overrun: dropping %u bytes\n",
size - room);
if (!room)
return room;
goto out;

tty_insert_flip_string(tport, sg_virt(&priv->sg_rx), size);

port->icount.rx += room;
out:
tty_kref_put(tty);

return room;
Expand Down

0 comments on commit 19b85cf

Please sign in to comment.