Skip to content

Commit

Permalink
leds: Rename led_brightness_set() to led_set_brightness()
Browse files Browse the repository at this point in the history
Rename leds external interface led_brightness_set() to led_set_brightness().
This is the second phase of the change to reduce confusion between the
leds internal and external interfaces that set brightness. With this change,
now the external interface is led_set_brightness(). The first phase renamed
the internal interface led_set_brightness() to __led_set_brightness().
There are no changes to the interface implementations.

Signed-off-by: Shuah Khan <shuahkhan@gmail.com>
Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
  • Loading branch information
Shuah Khan authored and Bryan Wu committed Jul 23, 2012
1 parent 0da3e65 commit 19cd67e
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion drivers/leds/led-class.c
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ void led_classdev_unregister(struct led_classdev *led_cdev)
#endif

/* Stop blinking */
led_brightness_set(led_cdev, LED_OFF);
led_set_brightness(led_cdev, LED_OFF);

device_unregister(led_cdev->dev);

Expand Down
4 changes: 2 additions & 2 deletions drivers/leds/led-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ void led_blink_set_oneshot(struct led_classdev *led_cdev,
}
EXPORT_SYMBOL(led_blink_set_oneshot);

void led_brightness_set(struct led_classdev *led_cdev,
void led_set_brightness(struct led_classdev *led_cdev,
enum led_brightness brightness)
{
/* stop and clear soft-blink timer */
Expand All @@ -113,4 +113,4 @@ void led_brightness_set(struct led_classdev *led_cdev,

__led_set_brightness(led_cdev, brightness);
}
EXPORT_SYMBOL(led_brightness_set);
EXPORT_SYMBOL(led_set_brightness);
2 changes: 1 addition & 1 deletion drivers/leds/led-triggers.c
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ void led_trigger_set(struct led_classdev *led_cdev, struct led_trigger *trig)
if (led_cdev->trigger->deactivate)
led_cdev->trigger->deactivate(led_cdev);
led_cdev->trigger = NULL;
led_brightness_set(led_cdev, LED_OFF);
led_set_brightness(led_cdev, LED_OFF);
}
if (trig) {
write_lock_irqsave(&trig->leddev_list_lock, flags);
Expand Down
2 changes: 1 addition & 1 deletion drivers/leds/ledtrig-oneshot.c
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ static void oneshot_trig_deactivate(struct led_classdev *led_cdev)
}

/* Stop blinking */
led_brightness_set(led_cdev, LED_OFF);
led_set_brightness(led_cdev, LED_OFF);
}

static struct led_trigger oneshot_led_trigger = {
Expand Down
2 changes: 1 addition & 1 deletion drivers/leds/ledtrig-timer.c
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ static void timer_trig_deactivate(struct led_classdev *led_cdev)
}

/* Stop blinking */
led_brightness_set(led_cdev, LED_OFF);
led_set_brightness(led_cdev, LED_OFF);
}

static struct led_trigger timer_led_trigger = {
Expand Down
4 changes: 2 additions & 2 deletions include/linux/leds.h
Original file line number Diff line number Diff line change
Expand Up @@ -124,15 +124,15 @@ extern void led_blink_set_oneshot(struct led_classdev *led_cdev,
unsigned long *delay_off,
int invert);
/**
* led_brightness_set - set LED brightness
* led_set_brightness - set LED brightness
* @led_cdev: the LED to set
* @brightness: the brightness to set it to
*
* Set an LED's brightness, and, if necessary, cancel the
* software blink timer that implements blinking when the
* hardware doesn't.
*/
extern void led_brightness_set(struct led_classdev *led_cdev,
extern void led_set_brightness(struct led_classdev *led_cdev,
enum led_brightness brightness);

/*
Expand Down
2 changes: 1 addition & 1 deletion net/mac80211/led.c
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ static void ieee80211_stop_tpt_led_trig(struct ieee80211_local *local)

read_lock(&tpt_trig->trig.leddev_list_lock);
list_for_each_entry(led_cdev, &tpt_trig->trig.led_cdevs, trig_list)
led_brightness_set(led_cdev, LED_OFF);
led_set_brightness(led_cdev, LED_OFF);
read_unlock(&tpt_trig->trig.leddev_list_lock);
}

Expand Down

0 comments on commit 19cd67e

Please sign in to comment.