Skip to content

Commit

Permalink
pinctrl: bcm: ns: Remove redundant dev_err call
Browse files Browse the repository at this point in the history
devm_ioremap_resource() prints error message in itself. Remove the
dev_err call to avoid redundant error message.

Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Ray Jui <ray.jui@broadcom.com>
Link: https://lore.kernel.org/r/20220923101038.18036-1-shangxiaojing@huawei.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
  • Loading branch information
Shang XiaoJing authored and Linus Walleij committed Oct 4, 2022
1 parent 8ea8af6 commit 19fdcb1
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/pinctrl/bcm/pinctrl-ns.c
Original file line number Diff line number Diff line change
Expand Up @@ -233,10 +233,8 @@ static int ns_pinctrl_probe(struct platform_device *pdev)
res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
"cru_gpio_control");
ns_pinctrl->base = devm_ioremap_resource(dev, res);
if (IS_ERR(ns_pinctrl->base)) {
dev_err(dev, "Failed to map pinctrl regs\n");
if (IS_ERR(ns_pinctrl->base))
return PTR_ERR(ns_pinctrl->base);
}

memcpy(pctldesc, &ns_pinctrl_desc, sizeof(*pctldesc));

Expand Down

0 comments on commit 19fdcb1

Please sign in to comment.