Skip to content

Commit

Permalink
drivers:iio:accel:mma8452: added cleanup provision in case of failure.
Browse files Browse the repository at this point in the history
mma8452_set_freefall_mode can return -ve value in case if
i2c_smbus_read_byte_data fails. This function is called from mma8452_probe,
and returning -ve value from probe indicates probe failure. Need to call
iio_triggered_buffer_cleanup & iio_trigger_cleanup in this case.

Signed-off-by: Bijosh Thykkoottathil <bijosh.t@hotmail.com>
Acked-by: Martin Kepplinger <martink@posteo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
  • Loading branch information
Bijosh Thykkoottathil authored and Jonathan Cameron committed Jul 5, 2016
1 parent 21d4165 commit 1a965d4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/iio/accel/mma8452.c
Original file line number Diff line number Diff line change
Expand Up @@ -1579,8 +1579,8 @@ static int mma8452_probe(struct i2c_client *client,
goto buffer_cleanup;

ret = mma8452_set_freefall_mode(data, false);
if (ret)
return ret;
if (ret < 0)
goto buffer_cleanup;

return 0;

Expand Down

0 comments on commit 1a965d4

Please sign in to comment.