Skip to content

Commit

Permalink
[MMC] Use class device name for mmc host name
Browse files Browse the repository at this point in the history
There's no point in having the host name duplicated between
the mmc_host structure and the encapsulated class device
structure.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Russell King authored and Russell King committed Aug 19, 2005
1 parent 00b137c commit 1ad434d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions drivers/mmc/mmc_sysfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -263,10 +263,9 @@ int mmc_add_host_sysfs(struct mmc_host *host)
{
static unsigned int host_num;

snprintf(host->host_name, sizeof(host->host_name),
snprintf(host->class_dev.class_id, BUS_ID_SIZE,
"mmc%d", host_num++);

strlcpy(host->class_dev.class_id, host->host_name, BUS_ID_SIZE);
return class_device_add(&host->class_dev);
}

Expand Down
3 changes: 1 addition & 2 deletions include/linux/mmc/host.h
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ struct mmc_host {
unsigned int f_min;
unsigned int f_max;
u32 ocr_avail;
char host_name[8];

/* host specific block data */
unsigned int max_seg_size; /* see blk_queue_max_segment_size */
Expand Down Expand Up @@ -98,7 +97,7 @@ extern void mmc_free_host(struct mmc_host *);

#define mmc_priv(x) ((void *)((x) + 1))
#define mmc_dev(x) ((x)->dev)
#define mmc_hostname(x) ((x)->host_name)
#define mmc_hostname(x) ((x)->class_dev.class_id)

extern int mmc_suspend_host(struct mmc_host *, pm_message_t);
extern int mmc_resume_host(struct mmc_host *);
Expand Down

0 comments on commit 1ad434d

Please sign in to comment.