Skip to content

Commit

Permalink
f2fs: don't bother wait_ms by foreground gc
Browse files Browse the repository at this point in the history
f2fs_gc returns -EINVAL via f2fs_balance_fs when there is enough free
secs after write checkpoint, but with gc_merge enabled, it will cause
the sleep time of gc thread to be set to no_gc_sleep_time even if there
are many dirty segments can be selected.

Signed-off-by: qixiaoyu1 <qixiaoyu1@xiaomi.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
  • Loading branch information
qixiaoyu1 authored and Jaegeuk Kim committed Jul 31, 2022
1 parent 0d5b9d8 commit 1adaa71
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions fs/f2fs/gc.c
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,11 @@ static int gc_thread_func(void *data)
gc_control.nr_free_secs = foreground ? 1 : 0;

/* if return value is not zero, no victim was selected */
if (f2fs_gc(sbi, &gc_control))
wait_ms = gc_th->no_gc_sleep_time;
if (f2fs_gc(sbi, &gc_control)) {
/* don't bother wait_ms by foreground gc */
if (!foreground)
wait_ms = gc_th->no_gc_sleep_time;
}

if (foreground)
wake_up_all(&gc_th->fggc_wq);
Expand Down

0 comments on commit 1adaa71

Please sign in to comment.