Skip to content

Commit

Permalink
mac80211: minstrel_ht: improve ampdu length estimation
Browse files Browse the repository at this point in the history
If the driver does not report A-MPDU length, estimate it based on the rate.

Signed-off-by: Felix Fietkau <nbd@nbd.name>
Link: https://lore.kernel.org/r/20210115120242.89616-6-nbd@nbd.name
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
  • Loading branch information
Felix Fietkau authored and Johannes Berg committed Jan 22, 2021
1 parent eeafcb0 commit 1ae8bba
Showing 1 changed file with 27 additions and 11 deletions.
38 changes: 27 additions & 11 deletions net/mac80211/rc80211_minstrel_ht.c
Original file line number Diff line number Diff line change
Expand Up @@ -382,13 +382,37 @@ minstrel_get_ratestats(struct minstrel_ht_sta *mi, int index)
return &mi->groups[index / MCS_GROUP_RATES].rates[index % MCS_GROUP_RATES];
}

static inline int minstrel_get_duration(int index)
{
const struct mcs_group *group = &minstrel_mcs_groups[index / MCS_GROUP_RATES];
unsigned int duration = group->duration[index % MCS_GROUP_RATES];

return duration << group->shift;
}

static unsigned int
minstrel_ht_avg_ampdu_len(struct minstrel_ht_sta *mi)
{
if (!mi->avg_ampdu_len)
return AVG_AMPDU_SIZE;
int duration;

if (mi->avg_ampdu_len)
return MINSTREL_TRUNC(mi->avg_ampdu_len);

if (minstrel_ht_is_legacy_group(mi->max_tp_rate[0] / MCS_GROUP_RATES))
return 1;

duration = minstrel_get_duration(mi->max_tp_rate[0]);

return MINSTREL_TRUNC(mi->avg_ampdu_len);
if (duration > 400 * 1000)
return 2;

if (duration > 250 * 1000)
return 4;

if (duration > 150 * 1000)
return 8;

return 16;
}

/*
Expand Down Expand Up @@ -588,14 +612,6 @@ minstrel_ht_prob_rate_reduce_streams(struct minstrel_ht_sta *mi)
}
}

static inline int
minstrel_get_duration(int index)
{
const struct mcs_group *group = &minstrel_mcs_groups[index / MCS_GROUP_RATES];
unsigned int duration = group->duration[index % MCS_GROUP_RATES];
return duration << group->shift;
}

static bool
minstrel_ht_probe_group(struct minstrel_ht_sta *mi, const struct mcs_group *tp_group,
int tp_idx, const struct mcs_group *group)
Expand Down

0 comments on commit 1ae8bba

Please sign in to comment.