Skip to content

Commit

Permalink
AGP: Warn when GATT memory cannot be set to UC
Browse files Browse the repository at this point in the history
This is one of those paranoid checks which should at least tell
us that something is about to go haywire after we've disabled
GART table walk probes which is done by default now on AMD.

Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
Cc: Dave Airlie <airlied@redhat.com>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
LKML-Reference: <1283531981-7495-4-git-send-email-bp@amd64.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Borislav Petkov authored and Ingo Molnar committed Sep 5, 2010
1 parent 260133a commit 1b13fe6
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/char/agp/generic.c
Original file line number Diff line number Diff line change
Expand Up @@ -984,7 +984,9 @@ int agp_generic_create_gatt_table(struct agp_bridge_data *bridge)

bridge->driver->cache_flush();
#ifdef CONFIG_X86
set_memory_uc((unsigned long)table, 1 << page_order);
if (set_memory_uc((unsigned long)table, 1 << page_order))
printk(KERN_WARNING "Could not set GATT table memory to UC!");

bridge->gatt_table = (void *)table;
#else
bridge->gatt_table = ioremap_nocache(virt_to_phys(table),
Expand Down

0 comments on commit 1b13fe6

Please sign in to comment.