Skip to content

Commit

Permalink
media: iguanair: fix endpoint sanity check
Browse files Browse the repository at this point in the history
Make sure to use the current alternate setting, which need not be the
first one by index, when verifying the endpoint descriptors and
initialising the URBs.

Failing to do so could cause the driver to misbehave or trigger a WARN()
in usb_submit_urb() that kernels with panic_on_warn set would choke on.

Fixes: 26ff631 ("[media] Add support for the IguanaWorks USB IR Transceiver")
Fixes: ab1cbdf ("media: iguanair: add sanity checks")
Cc: stable <stable@vger.kernel.org>     # 3.6
Cc: Oliver Neukum <oneukum@suse.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
  • Loading branch information
Johan Hovold authored and Mauro Carvalho Chehab committed Jan 9, 2020
1 parent 334f6aa commit 1b25787
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/media/rc/iguanair.c
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ static int iguanair_probe(struct usb_interface *intf,
int ret, pipein, pipeout;
struct usb_host_interface *idesc;

idesc = intf->altsetting;
idesc = intf->cur_altsetting;
if (idesc->desc.bNumEndpoints < 2)
return -ENODEV;

Expand Down

0 comments on commit 1b25787

Please sign in to comment.