Skip to content

Commit

Permalink
ARM: perf: remove unnecessary armpmu->stop
Browse files Browse the repository at this point in the history
As armpmu_disable will call armpmu->stop when the last event has been
removed, this is pointless and simply adds to the noise when debugging.
Additionally, due to this call occurring in a preemptible context, this
is problematic for per-cpu locking of PMU registers (where we will
attempt to access per-cpu spinlock for use with raw_spin_lock_irqsave).

This patch removes the call to armpmu->stop.

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Reviewed-by: Will Deacon <will.deacon@arm.com>
Reviewed-by: Jamie Iles <jamie@jamieiles.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
  • Loading branch information
Mark Rutland authored and Will Deacon committed Aug 31, 2011
1 parent 92f701e commit 1b69beb
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion arch/arm/kernel/perf_event.c
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,6 @@ armpmu_release_hardware(void)
free_irq(irq, NULL);
}

armpmu->stop();
release_pmu(ARM_PMU_DEVICE_CPU);
}

Expand Down

0 comments on commit 1b69beb

Please sign in to comment.