Skip to content

Commit

Permalink
dm table: improve warning message when devices not freed before destr…
Browse files Browse the repository at this point in the history
…uction

Report any devices forgotten to be freed before a table is destroyed.

Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
  • Loading branch information
Jonthan Brassow authored and Alasdair G Kergon committed Jun 22, 2009
1 parent f392ba8 commit 1b6da75
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions drivers/md/dm-table.c
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,8 @@ static void free_devices(struct list_head *devices)
list_for_each_safe(tmp, next, devices) {
struct dm_dev_internal *dd =
list_entry(tmp, struct dm_dev_internal, list);
DMWARN("dm_table_destroy: dm_put_device call missing for %s",
dd->dm_dev.name);
kfree(dd);
}
}
Expand Down Expand Up @@ -296,12 +298,8 @@ void dm_table_destroy(struct dm_table *t)
vfree(t->highs);

/* free the device list */
if (t->devices.next != &t->devices) {
DMWARN("devices still present during destroy: "
"dm_table_remove_device calls missing");

if (t->devices.next != &t->devices)
free_devices(&t->devices);
}

kfree(t);
}
Expand Down

0 comments on commit 1b6da75

Please sign in to comment.