Skip to content

Commit

Permalink
Revert "powerpc: Secondary CPUs must set cpu_callin_map after setting…
Browse files Browse the repository at this point in the history
… active and online"

This reverts commit 7c5c92e.

Although this did fix the bug it was aimed at, it also broke secondary
startup on platforms that use give/take_timebase(). Unfortunately we
didn't detect that while it was in next.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
  • Loading branch information
Michael Ellerman committed Dec 29, 2014
1 parent c1caae3 commit 1be6f10
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions arch/powerpc/kernel/smp.c
Original file line number Diff line number Diff line change
Expand Up @@ -700,6 +700,7 @@ void start_secondary(void *unused)
smp_store_cpu_info(cpu);
set_dec(tb_ticks_per_jiffy);
preempt_disable();
cpu_callin_map[cpu] = 1;

if (smp_ops->setup_cpu)
smp_ops->setup_cpu(cpu);
Expand Down Expand Up @@ -738,14 +739,6 @@ void start_secondary(void *unused)
notify_cpu_starting(cpu);
set_cpu_online(cpu, true);

/*
* CPU must be marked active and online before we signal back to the
* master, because the scheduler needs to see the cpu_online and
* cpu_active bits set.
*/
smp_wmb();
cpu_callin_map[cpu] = 1;

local_irq_enable();

cpu_startup_entry(CPUHP_ONLINE);
Expand Down

0 comments on commit 1be6f10

Please sign in to comment.