Skip to content

Commit

Permalink
HID: use BIT macro instead of plain integers for flags
Browse files Browse the repository at this point in the history
This can lead to some hairy situation with the developer losing
a day or two realizing that 4 should be after 2, not 3.

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Acked-by: Peter Hutterer <peter.hutterer@who-t.net>
--
 include/linux/hid.h | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
  • Loading branch information
Benjamin Tissoires authored and Jiri Kosina committed Mar 23, 2018
1 parent 843e475 commit 1c6ef16
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions include/linux/hid.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#define __HID_H


#include <linux/bitops.h>
#include <linux/types.h>
#include <linux/slab.h>
#include <linux/list.h>
Expand Down Expand Up @@ -494,13 +495,13 @@ struct hid_output_fifo {
char *raw_report;
};

#define HID_CLAIMED_INPUT 1
#define HID_CLAIMED_HIDDEV 2
#define HID_CLAIMED_HIDRAW 4
#define HID_CLAIMED_DRIVER 8
#define HID_CLAIMED_INPUT BIT(0)
#define HID_CLAIMED_HIDDEV BIT(1)
#define HID_CLAIMED_HIDRAW BIT(2)
#define HID_CLAIMED_DRIVER BIT(3)

#define HID_STAT_ADDED 1
#define HID_STAT_PARSED 2
#define HID_STAT_ADDED BIT(0)
#define HID_STAT_PARSED BIT(1)

struct hid_input {
struct list_head list;
Expand Down

0 comments on commit 1c6ef16

Please sign in to comment.