Skip to content

Commit

Permalink
io-wq: don't create any IO workers upfront
Browse files Browse the repository at this point in the history
When the manager thread starts up, it creates a worker per node for
the given context. Just let these get created dynamically, like we do
for adding further workers.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
Jens Axboe committed Feb 22, 2021
1 parent 7c25c0d commit 1cbd9c2
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions fs/io-wq.c
Original file line number Diff line number Diff line change
Expand Up @@ -759,18 +759,7 @@ static int io_wq_manager(void *data)
struct io_wq *wq = data;
int node;

/* create fixed workers */
refcount_set(&wq->refs, 1);
for_each_node(node) {
if (!node_online(node))
continue;
if (create_io_worker(wq, wq->wqes[node], IO_WQ_ACCT_BOUND))
continue;
set_bit(IO_WQ_BIT_ERROR, &wq->state);
set_bit(IO_WQ_BIT_EXIT, &wq->state);
goto out;
}

complete(&wq->done);

while (!kthread_should_stop()) {
Expand All @@ -796,7 +785,6 @@ static int io_wq_manager(void *data)
schedule_timeout(HZ);
}

out:
if (refcount_dec_and_test(&wq->refs)) {
complete(&wq->done);
return 0;
Expand Down

0 comments on commit 1cbd9c2

Please sign in to comment.