Skip to content

Commit

Permalink
cirrusfb: remove 24 bpp mode
Browse files Browse the repository at this point in the history
The 24 bpp mode is not implemented.  Disallow it in the
cirrusfb_check_var() and remove it from checks.

Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Krzysztof Helt authored and Linus Torvalds committed Oct 16, 2008
1 parent 7528f54 commit 1cea9a9
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions drivers/video/cirrusfb.c
Original file line number Diff line number Diff line change
Expand Up @@ -638,7 +638,6 @@ static int cirrusfb_check_var(struct fb_var_screeninfo *var,
break; /* 8 pixel per byte, only 1/4th of mem usable */
case 8:
case 16:
case 24:
case 32:
break; /* 1 pixel == 1 byte */
default:
Expand Down Expand Up @@ -713,7 +712,6 @@ static int cirrusfb_check_var(struct fb_var_screeninfo *var,
var->blue.length = 5;
break;

case 24:
case 32:
if (isPReP) {
var->red.offset = 8;
Expand Down Expand Up @@ -782,7 +780,6 @@ static int cirrusfb_decode_var(const struct fb_var_screeninfo *var,
break;

case 16:
case 24:
case 32:
info->fix.line_length = var->xres_virtual * maxclockidx;
info->fix.visual = FB_VISUAL_DIRECTCOLOR;
Expand Down Expand Up @@ -1360,7 +1357,7 @@ static int cirrusfb_set_par_foo(struct fb_info *info)
*/

else if (var->bits_per_pixel == 32) {
DPRINTK("cirrusfb: preparing for 24/32 bit deep display\n");
DPRINTK("cirrusfb: preparing for 32 bit deep display\n");
switch (cinfo->btype) {
case BT_SD64:
/* Extended Sequencer Mode: 256c col. mode */
Expand Down Expand Up @@ -2233,7 +2230,7 @@ static int cirrusfb_set_fbinfo(struct fb_info *info)
if (cinfo->btype == BT_GD5480) {
if (var->bits_per_pixel == 16)
info->screen_base += 1 * MB_;
if (var->bits_per_pixel == 24 || var->bits_per_pixel == 32)
if (var->bits_per_pixel == 32)
info->screen_base += 2 * MB_;
}

Expand Down

0 comments on commit 1cea9a9

Please sign in to comment.