Skip to content

Commit

Permalink
RDMA/rxe: Remove the is_user members of struct rxe_sq/rxe_rq/rxe_srq
Browse files Browse the repository at this point in the history
The is_user members of struct rxe_sq/rxe_rq/rxe_srq are unsed since
commit ae6e843 ("RDMA/rxe: Add memory barriers to kernel queues").
In this case, it is fine to remove them directly.

Link: https://lore.kernel.org/r/20210930094813.226888-2-yangx.jy@fujitsu.com
Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
  • Loading branch information
Xiao Yang authored and Jason Gunthorpe committed Oct 6, 2021
1 parent 0de71d7 commit 1cf2ce8
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 9 deletions.
2 changes: 0 additions & 2 deletions drivers/infiniband/sw/rxe/rxe_qp.c
Original file line number Diff line number Diff line change
Expand Up @@ -307,8 +307,6 @@ static int rxe_qp_init_resp(struct rxe_dev *rxe, struct rxe_qp *qp,
spin_lock_init(&qp->rq.producer_lock);
spin_lock_init(&qp->rq.consumer_lock);

qp->rq.is_user = qp->is_user;

skb_queue_head_init(&qp->resp_pkts);

rxe_init_task(rxe, &qp->resp.task, qp,
Expand Down
1 change: 0 additions & 1 deletion drivers/infiniband/sw/rxe/rxe_srq.c
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ int rxe_srq_from_init(struct rxe_dev *rxe, struct rxe_srq *srq,
srq->srq_num = srq->pelem.index;
srq->rq.max_wr = init->attr.max_wr;
srq->rq.max_sge = init->attr.max_sge;
srq->rq.is_user = srq->is_user;

srq_wqe_size = rcv_wqe_size(srq->rq.max_sge);

Expand Down
3 changes: 0 additions & 3 deletions drivers/infiniband/sw/rxe/rxe_verbs.c
Original file line number Diff line number Diff line change
Expand Up @@ -267,9 +267,6 @@ static int rxe_create_srq(struct ib_srq *ibsrq, struct ib_srq_init_attr *init,
if (udata->outlen < sizeof(*uresp))
return -EINVAL;
uresp = udata->outbuf;
srq->is_user = true;
} else {
srq->is_user = false;
}

err = rxe_srq_chk_attr(rxe, NULL, &init->attr, IB_SRQ_INIT_MASK);
Expand Down
3 changes: 0 additions & 3 deletions drivers/infiniband/sw/rxe/rxe_verbs.h
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ enum wqe_state {
};

struct rxe_sq {
bool is_user;
int max_wr;
int max_sge;
int max_inline;
Expand All @@ -86,7 +85,6 @@ struct rxe_sq {
};

struct rxe_rq {
bool is_user;
int max_wr;
int max_sge;
spinlock_t producer_lock; /* guard queue producer */
Expand All @@ -100,7 +98,6 @@ struct rxe_srq {
struct rxe_pd *pd;
struct rxe_rq rq;
u32 srq_num;
bool is_user;

int limit;
int error;
Expand Down

0 comments on commit 1cf2ce8

Please sign in to comment.